Core: fix missing deprecation when accessing null array key with JIT #20883
+9
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iluuu1994
reviewed
Jan 9, 2026
alexandre-daubois
force-pushed
the
jit-array-null-key
branch
from
535d9f3 to
225faac
Compare
dstogov
approved these changes
Jan 12, 2026
Member
dstogov
left a comment
dstogov
left a comment
There was a problem hiding this comment.
See minor note.
Everything else looks fine.
alexandre-daubois
force-pushed
the
jit-array-null-key
branch
from
225faac to
7522b0c
Compare
alexandre-daubois
force-pushed
the
jit-array-null-key
branch
from
7522b0c to
681ef28
Compare
iluuu1994
reviewed
Jan 12, 2026
| static inline zend_result ct_eval_isset_dim(zval *result, uint32_t extended_value, zval *op1, zval *op2) { | ||
| if (Z_TYPE_P(op2) == IS_NULL) { | ||
| return FAILURE; | ||
| } |
Member
There was a problem hiding this comment.
Is this still necessary? Shouldn't fetch_array_elem() already handle it?
Member
Author
There was a problem hiding this comment.
I would say it is. If op1 is not an array (e.g. isset($a[null])), the condition below this one (if (Z_TYPE_P(op1) == IS_ARRAY || IS_PARTIAL_ARRAY(op1)) {) would be false and we would completely ditch any check on a null key.
Adding this early return avoids compile-time checks that would silence this kind of operation. If I get it right 😄
Member
There was a problem hiding this comment.
The deprecation was only added for arrays though, as far as I understand.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Missing deprecation raised in #20857