Support rendering release pages with PHP 8.3+ #1613
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theodorejb
requested review from
derickr,
saundefined,
sgolemon and
sy-records
as code owners
Contributor
|
🚀 Regression report for commit 84ce0c6 is at https://web-php-regression-report-pr-1613.preview.thephp.foundation |
Contributor
|
🚀 Preview for commit 84ce0c6 can be found at https://web-php-pr-1613.preview.thephp.foundation |
theodorejb
force-pushed
the
support-php-83-plus
branch
from
15377d7 to
2efa269
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this patch, when release pages are rendered with PHP 8.3+ the code blocks are missing line breaks and have extra margin on the
<pre>element:This pull request fixes the code blocks to render identically on PHP 8.2 and 8.3+.
I also verified that documentation page examples are not broken or affected by this change.