Skip to content

Conversation

pupik-pixel
Copy link
Contributor

update phpactor/phpactor package to 2025.07.25.0

update phpactor/phpactor package to 2025.07.25.0
@pupik-pixel
Copy link
Contributor Author

Guys, can this happen automatically?

@zobo
Copy link
Collaborator

zobo commented Oct 14, 2025

The release was here https://github.com/phpactor/vscode-phpactor/releases/tag/1.7.3

Do you use composer.json ?

Phpactor didn't work very well from composer.json

I can try to get dependabot to update this file too.

@pupik-pixel
Copy link
Contributor Author

The release was here https://github.com/phpactor/vscode-phpactor/releases/tag/1.7.3

Do you use composer.json ?

Phpactor didn't work very well from composer.json

I can try to get dependabot to update this file too.

I don't use composer on all of my projects. And on the projects that I do use, it's not a good idea to install this package

@pupik-pixel
Copy link
Contributor Author

@zobo How do I install a phar file inside the extension?

@zobo
Copy link
Collaborator

zobo commented Oct 16, 2025

Hi, sorry I missed your response. While the extension is built, the latest phpactor phar is downloaded (see https://github.com/phpactor/vscode-phpactor/blob/4e42ce6d8592cb91a208ebe4d8e4ce8e079e9aee/package.json#L21C10-L21C26) and then packed into the final vsix.
When you install the extension from the store it will already contain the latest phpactor.
What are you trying to do?
If you want to use your own version of phpactor outside of the extension, look at the extension settings phpactor.path or phpactor.remote.*

@pupik-pixel
Copy link
Contributor Author

pupik-pixel commented Oct 16, 2025

in theory, it also uses the old installation from this folder ~/.vscode-server/extensions/phpactor.vscode-phpactor-1.7.3/vendor/phpactor/phpactor/bin/.

parameter from config
"language_server.phpactor_bin": "/var/www/.vscode-server/extensions/phpactor.vscode-phpactor-1.7.3/vendor/phpactor/phpactor/bin/phpactor",

used version in extension 2025.04.17.0

so far, I'm using my own version with installation via postCreateCommand in devcontainer.

@zobo
Copy link
Collaborator

zobo commented Oct 16, 2025

I went back and looked at this and indeed the extension uses the vendorized phpactor and not phar. I have to recheck this as I've clearly forgotten what I did...
Thanks for pointing this out. Will make and updated release asap.

@zobo zobo changed the title chore: update phpactor package fix: update phpactor package to 2025-07-25.0 Oct 16, 2025
@zobo
Copy link
Collaborator

zobo commented Oct 16, 2025

I needed GPT to point out the problem why renovate didn't update the version. It's name is 2025-07-25.0 instead of 2025.07.25.0.

@zobo zobo merged commit 2688926 into phpactor:master Oct 16, 2025
1 check passed
@pupik-pixel
Copy link
Contributor Author

Thx 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants