wip

Author: micheleorselli

src/PHPUnit/ArchRuleCheckerConstraintAdapter.php

@@ -9,6 +9,7 @@
 use Arkitect\ClassSet;
 use Arkitect\ClassSetRules;
 use Arkitect\CLI\Printer\Printer;
+use Arkitect\CLI\Printer\PrinterFactory;
 use Arkitect\CLI\Progress\VoidProgress;
 use Arkitect\CLI\Runner;
 use Arkitect\CLI\TargetPhpVersion;
@@ -40,6 +41,8 @@ class ArchRuleCheckerConstraintAdapter extends Constraint
     /** @var ParsingErrors */
     private $parsingErrors;
 
+    private Printer $printer;
+
     public function __construct(ClassSet $classSet)
     {
         $targetPhpVersion = TargetPhpVersion::create(null);
@@ -48,6 +51,7 @@ public function __construct(ClassSet $classSet)
         $this->classSet = $classSet;
         $this->violations = new Violations();
         $this->parsingErrors = new ParsingErrors();
+        $this->printer = PrinterFactory::create(Printer::FORMAT_TEXT);
     }
 
     public function toString(): string
@@ -80,6 +84,6 @@ protected function failureDescription($other): string
             return "\n parsing error: ".$this->parsingErrors->toString();
         }
 
-        return "\n".$this->violations->toString(Printer::FORMAT_TEXT);
+        return "\n".$this->printer->print($this->violations->groupedByFqcn());
     }
 }

src/Rules/Violations.php

@@ -4,7 +4,6 @@
 
 namespace Arkitect\Rules;
 
-use Arkitect\CLI\Printer\PrinterFactory;
 use Arkitect\Exceptions\IndexNotFoundException;
 
 /**
@@ -75,13 +74,6 @@ public function groupedByFqcn(): array
         }, []);
     }
 
-    public function toString(string $format): string
-    {
-        $printer = (new PrinterFactory())->create($format);
-
-        return $printer->print($this->groupedByFqcn());
-    }
-
     public function toArray(): array
     {
         return $this->violations;

tests/Unit/CLI/Printer/PrinterFactoryTest.php

@@ -15,9 +15,7 @@ class PrinterFactoryTest extends TestCase
      */
     public function test_create_returns_json_printer_for_json_format(): void
     {
-        $factory = new PrinterFactory();
-
-        $printer = $factory->create('json');
+        $printer = PrinterFactory::create('json');
 
         self::assertInstanceOf(JsonPrinter::class, $printer);
     }
@@ -27,9 +25,7 @@ public function test_create_returns_json_printer_for_json_format(): void
      */
     public function test_create_returns_text_printer_for_non_json_format(): void
     {
-        $factory = new PrinterFactory();
-
-        $printer = $factory->create('text');
+        $printer = PrinterFactory::create('text');
 
         self::assertInstanceOf(TextPrinter::class, $printer);
     }

tests/Unit/Rules/ViolationsTest.php

@@ -4,7 +4,6 @@
 
 namespace Arkitect\Tests\Unit\Rules;
 
-use Arkitect\CLI\Printer\Printer;
 use Arkitect\Exceptions\IndexNotFoundException;
 use Arkitect\Rules\Violation;
 use Arkitect\Rules\Violations;
@@ -48,26 +47,6 @@ public function test_count(): void
         self::assertEquals(2, $this->violationStore->count());
     }
 
-    public function test_to_string(): void
-    {
-        $violation = new Violation(
-            'App\Controller\Foo',
-            'should have name end with Controller'
-        );
-
-        $this->violationStore->add($violation);
-
-        $expected = <<<'ERRORS'
-        App\Controller\ProductController has 1 violations
-          should implement ContainerInterface
-
-        App\Controller\Foo has 1 violations
-          should have name end with Controller
-        ERRORS;
-
-        self::assertStringContainsString($expected, $this->violationStore->toString(Printer::FORMAT_TEXT));
-    }
-
     public function test_get_iterable(): void
     {
         $violation = new Violation(