Bug: dependencies leak between files #445
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simivar
commented
Jan 31, 2025
| public function clearParsedClassDescriptions(): void | ||
| { | ||
| $this->classDescriptions = []; | ||
| $this->classDescriptionBuilder->clear(); |
Contributor
Author
There was a problem hiding this comment.
@AlessandroMinoccheri this one line is basically the fix for this issue that I reported 2 years ago 🥹. In order for the tests to run on pipelines I had to run CS Fixer too. Please review
Member
There was a problem hiding this comment.
@simivar the build pipeline is fixed and phpcsfixer is pinned to a specific version so this should not produce different result based on the php version anymore. Would you mind rebasing to master and committing only the line that fix the problem you mention? Thanks! 🙇
Contributor
Author
There was a problem hiding this comment.
@micheleorselli the Mr now contains only necessary bugfix changes
micheleorselli
approved these changes
Feb 26, 2025
Member
|
thank you @simivar! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a failing test for #389, please see it for more details.