Skip to content

Conversation

@micheleorselli
Copy link
Member

@micheleorselli micheleorselli commented Feb 10, 2025

  • added php 8.4 to the build matrix
  • do static checks only on php 7.4 to avoid random results
  • upgraded PHP Parser to version 5 to be able to parse php 8.4 code
  • added a test to verify php 8.4 can be parsed
  • updated our custom NameResolver (ugly, we should find a way to avoid that 😅)

@codecov
Copy link

codecov bot commented Feb 10, 2025

Codecov Report

Attention: Patch coverage is 64.28571% with 5 lines in your changes missing coverage. Please review.

Project coverage is 93.85%. Comparing base (cda58ca) to head (a8725ca).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/Analyzer/NameResolver.php 61.53% 5 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #447      +/-   ##
============================================
- Coverage     94.15%   93.85%   -0.30%     
- Complexity      588      591       +3     
============================================
  Files            69       69              
  Lines          1590     1594       +4     
============================================
- Hits           1497     1496       -1     
- Misses           93       98       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@micheleorselli micheleorselli changed the title testing php 8.4 Add php 8.4 to build matrix Feb 12, 2025
@micheleorselli micheleorselli changed the title Add php 8.4 to build matrix Support php 8.4 Feb 12, 2025
@micheleorselli micheleorselli marked this pull request as ready for review February 12, 2025 23:05
@micheleorselli micheleorselli merged commit 483b878 into main Feb 13, 2025
32 of 34 checks passed
@micheleorselli micheleorselli deleted the support-php-84 branch March 13, 2025 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants