Skip to content

Fixes implements and extends rules behaviour #456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 10, 2025

Conversation

micheleorselli
Copy link
Member

This should provide a fix for #393

Copy link

codecov bot commented Mar 7, 2025

Codecov Report

Attention: Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.

Project coverage is 94.75%. Comparing base (fd47236) to head (d864a78).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/Expression/ForClasses/NotImplement.php 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #456      +/-   ##
============================================
- Coverage     94.79%   94.75%   -0.04%     
- Complexity      606      611       +5     
============================================
  Files            69       69              
  Lines          1614     1621       +7     
============================================
+ Hits           1530     1536       +6     
- Misses           84       85       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@AlessandroMinoccheri AlessandroMinoccheri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to specify something more in the documentation @micheleorselli ?

@micheleorselli
Copy link
Member Author

Do we need to specify something more in the documentation @micheleorselli ?

uhm, not really sure, we can probably specify the difference between implements and extends maybe?

@micheleorselli micheleorselli force-pushed the implements_throwable_bug branch from 646c6f6 to d864a78 Compare March 10, 2025 20:35
@micheleorselli micheleorselli merged commit bb5a7e7 into main Mar 10, 2025
32 of 34 checks passed
@micheleorselli micheleorselli deleted the implements_throwable_bug branch March 10, 2025 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants