Skip to content

Conversation

@micheleorselli
Copy link
Member

@micheleorselli micheleorselli commented May 21, 2025

some more refactorings before tackling the @throws tag dependency collection

  1. refactored to avoid nested conditionals
  2. preferred checks like $node->class instanceof Node\Name\FullyQualified instead of method_exists($node->class, 'toString'). This allows to skip checks on parent:: self:: static:: and native types since a Node\Name\FullyQualified refers always to a class

@codecov
Copy link

codecov bot commented May 21, 2025

Codecov Report

Attention: Patch coverage is 96.05263% with 3 lines in your changes missing coverage. Please review.

Project coverage is 97.75%. Comparing base (556c3f1) to head (7302707).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/Analyzer/FileVisitor.php 96.05% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #512      +/-   ##
============================================
+ Coverage     97.47%   97.75%   +0.27%     
+ Complexity      631      615      -16     
============================================
  Files            80       80              
  Lines          1785     1778       -7     
============================================
- Hits           1740     1738       -2     
+ Misses           45       40       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@micheleorselli micheleorselli marked this pull request as ready for review May 21, 2025 19:50
Copy link
Member

@AlessandroMinoccheri AlessandroMinoccheri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarqubecloud
Copy link

@micheleorselli micheleorselli merged commit 12f0a78 into main May 22, 2025
34 of 35 checks passed
@micheleorselli micheleorselli deleted the simplfy_filevisitor branch May 22, 2025 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants