Remove unnecessary Psalm suppressions from ProgressBarProgress #545
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #299 The @psalm-suppress UndefinedDocblockClass and @psalm-suppress UndefinedClass annotations are no longer needed in ProgressBarProgress.php because: - All imported classes (OutputInterface, ProgressBar, NullOutput) are from symfony/console, which is a required dependency - CiDetector is from ondram/ci-detector, which is a required dependency - ClassSet and Progress are from the same project namespace - All type annotations in docblocks properly reference imported classes All tests pass successfully after removing these suppressions.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #545 +/- ##
=========================================
Coverage 97.75% 97.75%
Complexity 616 616
=========================================
Files 80 80
Lines 1779 1779
=========================================
Hits 1739 1739
Misses 40 40 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #299
The @psalm-suppress UndefinedDocblockClass and @psalm-suppress UndefinedClass annotations are no longer needed in ProgressBarProgress.php because:
All tests pass successfully after removing these suppressions.