DisableConstructorPatch: make optional constructor parameters nullable explicitly#632
Merged
stof merged 1 commit intophpspec:masterfrom Oct 11, 2024
W0rma:php84-explicit-nullable-types
Merged
DisableConstructorPatch: make optional constructor parameters nullable explicitly#632stof merged 1 commit intophpspec:masterfrom W0rma:php84-explicit-nullable-types
stof merged 1 commit intophpspec:masterfrom
W0rma:php84-explicit-nullable-types
Conversation
stof
requested changes
Oct 4, 2024
| \assert($constructor !== null); | ||
| foreach ($constructor->getArguments() as $argument) { | ||
| $argument->setDefault(null); | ||
| if (\PHP_VERSION_ID < 80400) { |
Member
There was a problem hiding this comment.
I suggest doing that for all versions instead, to avoid different behavior between PHP versions (making a type explicitly nullable is supported on PHP 7.1+, which covers more than our target versions)
| } | ||
|
|
||
| $types = $argument->getTypeNode()->getNonNullTypes(); | ||
| if ([] == $types || ['mixed'] == $types) { |
Implicitly nullable types are deprecated in PHP 8.4
Contributor
Author
|
#633 should fix the CI (cs fixer + phpstan) |
Jean85
approved these changes
Oct 11, 2024
Contributor
|
This should receive the PHP 8.4 label |
Jean85
added a commit
to facile-it/paraunit
that referenced
this pull request
Oct 30, 2024
Jean85
added a commit
to facile-it/paraunit
that referenced
this pull request
Nov 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR tries to fix #625 (comment)