Microoptimize AssertRuleHelper.

phpstan · May 26, 2023 · d8bdab0 · d8bdab0
1 parent 9e928dd
commit d8bdab0
Showing 1 changed file with 2 additions and 5 deletions.
diff --git a/src/Rules/PHPUnit/AssertRuleHelper.php b/src/Rules/PHPUnit/AssertRuleHelper.php
@@ -16,7 +16,6 @@ class AssertRuleHelper
 	 */
 	public static function isMethodOrStaticCallOnAssert(Node $node, Scope $scope): bool
 	{
-		$testCaseType = new ObjectType('PHPUnit\Framework\Assert');
 		if ($node instanceof Node\Expr\MethodCall) {
 			$calledOnType = $scope->getType($node->var);
 		} elseif ($node instanceof Node\Expr\StaticCall) {
@@ -45,11 +44,9 @@ public static function isMethodOrStaticCallOnAssert(Node $node, Scope $scope): b
 			return false;
 		}
 
-		if (!$testCaseType->isSuperTypeOf($calledOnType)->yes()) {
-			return false;
-		}
+		$testCaseType = new ObjectType('PHPUnit\Framework\Assert');
 
-		return true;
+		return $testCaseType->isSuperTypeOf($calledOnType)->yes();
 	}
 
 }