Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ynab-api: Implement getting an Account by its ID #14

Closed
phrohdoh opened this issue Jun 12, 2019 · 2 comments
Closed

ynab-api: Implement getting an Account by its ID #14

phrohdoh opened this issue Jun 12, 2019 · 2 comments
Labels
comp:ynab-api Pertains to the `ynab-api` component

Comments

@phrohdoh
Copy link
Owner

Similar to #4 and #13 we need to be able to get an Account by id.
@phrohdoh phrohdoh added the comp:ynab-api Pertains to the `ynab-api` component label Jun 12, 2019
@phrohdoh phrohdoh mentioned this issue Jun 12, 2019
Open
bgigous pushed a commit to bgigous/ynab-rs that referenced this issue Feb 20, 2022
ynab-api: Implement getting an Account by its ID
43993bf 
- Add `direct_import_linked` and `direct_import_in_error` boolean fields
  to `Account` type
- Make `note` field in `Account` type optional
- Append authorship of crate
- Implements issue phrohdoh#14
@bgigous bgigous mentioned this issue Feb 20, 2022
Merged
@bgigous
Copy link

bgigous commented Feb 20, 2022

Good day.

I made a pull request here for this issue and for #15 in a PR (#17). Not sure if I did the PR "correctly" but waiting for review.

phrohdoh pushed a commit that referenced this issue Feb 22, 2022
@phrohdoh
ynab-api: Implement getting an Account by its ID
110e089 
- Add `direct_import_linked` and `direct_import_in_error` boolean fields
  to `Account` type
- Make `note` field in `Account` type optional
- Append authorship of crate
- Implements issue #14
@phrohdoh
Copy link
Owner Author

This can be closed given #17 has been merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
comp:ynab-api Pertains to the `ynab-api` component
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bgigous @phrohdoh