Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pull Request: Implement getting an Account by its ID #17

Merged
merged 2 commits into from
Feb 22, 2022
Merged

Pull Request: Implement getting an Account by its ID #17

merged 2 commits into from
Feb 22, 2022

Conversation

bgigous
Copy link

@bgigous bgigous commented Feb 20, 2022

ynab-api: Implement getting an Account by its ID
43993bf 
- Add `direct_import_linked` and `direct_import_in_error` boolean fields
  to `Account` type
- Make `note` field in `Account` type optional
- Append authorship of crate
- Implements issue phrohdoh#14
@bgigous bgigous changed the title ynab-api: Implement getting an Account by its ID Pull Request: Implement getting an Account by its ID Feb 20, 2022
@bgigous
Copy link
Author

bgigous commented Feb 20, 2022

I am sure that parts of get_category_by_id function could be split up and made more general for both getting categories and accounts by ID, but I am very new to Rust programming and don't know how to go about that. It is my first contribution to a Rust codebase. Would love feedback! I also welcome edits.

ynab-cli: Implement getting an Account by its ID
29a7895 
- Add new get-account-by-id subcommand and description to CLI
@bgigous bgigous mentioned this pull request Feb 20, 2022
Closed
@bgigous
Copy link
Author

bgigous commented Feb 20, 2022

Push changes to solve #15

phrohdoh
phrohdoh approved these changes Feb 22, 2022
View reviewed changes
Copy link
Owner

@phrohdoh phrohdoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good as-is, thank you!

@phrohdoh phrohdoh merged commit 241fed9 into phrohdoh:master Feb 22, 2022
@phrohdoh
Copy link
Owner

Also, if you'd like to chat asynchronously (about these changes, this codebase, Rust, etc), I can be reached at @phrohdoh:matrix.org (see https://matrix.org for more info) and am happy to talk/help!

@bgigous bgigous deleted the feat/ynab-api-account-by-id branch February 27, 2022 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phrohdoh phrohdoh phrohdoh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bgigous @phrohdoh