Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for "support data" #49

Merged
merged 10 commits into from
Jul 8, 2023
Merged

Conversation

smoia
Copy link
Member

@smoia smoia commented Sep 23, 2021

Closes none but addresses physiopy/prep4phys#19
Depends on #42

This PR add the possibility to plot a secondary (support) physiological wave in the interactive editor.
The secondary wave is not editable, but visualising multiple physiological signals together allows a manual peak edit to be informed by other fluctuations.
A use case is, for instance, peak addition/rejection in a CO2/O2 trace in data without a direct CO2/O2 manipulation.
Plotting a respiratory belt allows to better classify peculiar CO2/O2 fluctuations (e.g. a period of fluctuations within a smaller range than normal) as instrumental artefacts or real changes in respiration.

Proposed Changes

  • Add a suppdata (support data) property and parameter in the Physio object, as well as a parameter in the PhysioEditor object.
  • Allow plotting of secondary row only in case suppdata contains data.

Change Type

  • bugfix (+0.0.1)
  • minor (+0.1.0)
  • major (+1.0.0)
  • refactoring (no version update)
  • test (no version update)
  • infrastructure (no version update)
  • documentation (no version update)
  • other

Checklist before review

  • I added everything I wanted to add to this PR.
  • [Code or tests only] I wrote/updated the necessary docstrings.
  • [Code or tests only] I ran and passed tests locally.
  • [Documentation only] I built the docs locally.
  • My contribution is harmonious with the rest of the code: I'm not introducing repetitions.
  • My code respects the adopted style, especially linting conventions.
  • The title of this PR is explanatory on its own, enough to be understood as part of a changelog.
  • I added or indicated the right labels.
  • I added information regarding the timeline of completion for this PR.
  • Please, comment on my PR while it's a draft and give me feedback on the development!

@smoia smoia added Minormod This PR generally closes an "Enhancement" issue. It increments the minor version (0.+1.0) Paused Issue should not be worked on until the resolution of other issues or Pull Requests labels Sep 23, 2021
@smoia smoia merged commit 720c8f6 into physiopy:master Jul 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Minormod This PR generally closes an "Enhancement" issue. It increments the minor version (0.+1.0) Paused Issue should not be worked on until the resolution of other issues or Pull Requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants