-
Notifications
You must be signed in to change notification settings - Fork 19
Complete overwrite of RETROICOR computation to allow multiple physiological modalities and their interactions #70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…hysiological data (like most other metrics) and vectorised for efficiency.
…ta types entry and for interactions!
for more information, see https://pre-commit.ci
Also @alaurasparsi this is of interest for you! |
Co-authored-by: Stefano Moia <[email protected]> Co-authored-by: alaurasparsi <[email protected]>
Co-authored-by: Stefano Moia <[email protected]> Co-authored-by: alaurasparsi <[email protected]>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #70 +/- ##
==========================================
- Coverage 53.85% 44.55% -9.31%
==========================================
Files 8 9 +1
Lines 596 606 +10
==========================================
- Hits 321 270 -51
- Misses 275 336 +61
🚀 New features to boost your workflow:
|
Retroicor regressors are organised in a dictionary of two dictionaries, one for | ||
retroicor regressors and one for phases. These dictionaries have one entry per | ||
slice. | ||
All entries are lists, always organised: cardiac regressors first, then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes more sense to invert order to follow input order
Closes #
Turns out (or so I think) we were computing RETROICOR in a horrible (if not wrong) way due to a few oversights from reviewers (me included) and code authors.
In fixing the issues, I decided to just rewrite everything to improve computation and allow for interactive effects to be computed.
Proposed Changes
Phases:
Consequently, RETROICOR:
Tagging @CesarCaballeroGaudes @afni-dglen @mrikasper because of your expertise with RETROICOR and its implementation in code. Tagging @m-miedema and @me-pic for your expertise on phys2denoise.
Change Type
bugfix
(+0.0.1)minor
(+0.1.0)major
(+1.0.0)refactoring
(no version update)test
(no version update)infrastructure
(no version update)documentation
(no version update)other
Checklist before review