Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Circle with two origins fresh #1176

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

GeoffreySangston
Copy link
Collaborator

@GeoffreySangston GeoffreySangston commented Dec 31, 2024

Continuing from here #1159 (comment)

Sorry for the confusion. I didn't realize my commits weren't going through because the PR was already closed, and I didn't notice the error message.

@GeoffreySangston GeoffreySangston marked this pull request as ready for review December 31, 2024 00:41
@prabau
Copy link
Collaborator

prabau commented Dec 31, 2024

I am not entirely sure what an "assignee" is, maybe someone assigned to work on the PR? We could be assigned as reviewers instead.

In any case, this change looks fine to me. Approving but not merging, so @Moniker1998 can comment.

prabau
prabau previously approved these changes Dec 31, 2024
@GeoffreySangston
Copy link
Collaborator Author

I am not entirely sure what an "assignee" is, maybe someone assigned to work on the PR?

Wow I really am distracted!

@Moniker1998
Copy link
Collaborator

I think merging of this should wait till we decide about nomenclature regarding (one-point) compactifications
See #1174

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants