Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add libidn2, remove libidn #87

Merged
merged 1 commit into from
Nov 20, 2023
Merged

Add libidn2, remove libidn #87

merged 1 commit into from
Nov 20, 2023

Conversation

DL6ER
Copy link
Member

@DL6ER DL6ER commented Nov 20, 2023

What does this implement/fix?

Remove self-compiled libidn and, instead, use libidn2 as provided by Alpine itself


Related issue or feature (if applicable): N/A

Pull request in docs with documentation (if applicable): N/A


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)

Checklist:

  • The code change is tested and works locally.
  • I based my code and PRs against the repositories developmental branch.
  • I signed off all commits. Pi-hole enforces the DCO for all contributions
  • I signed all my commits. Pi-hole requires signatures to verify authorship
  • I have read the above and my PR is ready for review.

@DL6ER DL6ER requested a review from a team November 20, 2023 08:21
@DL6ER DL6ER changed the title Switch from IDNA2003 to IDNA2008 Add libidn2, remove libidn Nov 20, 2023
@DL6ER DL6ER merged commit c4420c3 into master Nov 20, 2023
7 checks passed
@DL6ER DL6ER deleted the ftl-build/idn2 branch November 20, 2023 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants