Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DNSMASQ_LISTENING=bind to README.md #1615

Merged
merged 1 commit into from
Jul 28, 2024
Merged

Conversation

loeffelpan
Copy link

Description

Adding missing option bind for DNSMASQ_LISTENING.

Motivation and Context

See https://discourse.pi-hole.net/t/dnsmasq-listening-setting-for-binding-single-interface/71417/6

How Has This Been Tested?

Tested the additional bind option in my production environment.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation change/addition

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/dnsmasq-listening-setting-for-binding-single-interface/71417/7

@yubiuser
Copy link
Member

You need to sign-off your commit https://docs.pi-hole.net/guides/github/how-to-signoff/

Copy link
Member

@rdwebdesign rdwebdesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note:

I don't think we need a new image tag when this is merged because this only changes the README file.

@PromoFaux PromoFaux merged commit 6568baf into pi-hole:dev Jul 28, 2024
5 checks passed
@loeffelpan loeffelpan deleted the dev branch July 28, 2024 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants