Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PIA-675: TVOS Compatibility #17

Merged
merged 1 commit into from
Nov 22, 2023
Merged

Conversation

kp-said-rehouni
Copy link
Collaborator

Summary

This PR adds compatibility to tvOS and removes all the UI code and resources to the main application in order to compile for iOS and tvOS.

@kp-said-rehouni kp-said-rehouni force-pushed the PIA-675_tvOS_compatibility branch 3 times, most recently from 077ab91 to 4b2f31e Compare November 7, 2023 18:49
@kp-said-rehouni kp-said-rehouni force-pushed the PIA-675_tvOS_compatibility branch 5 times, most recently from bdbf219 to 6bf20bb Compare November 8, 2023 06:45
kp-juan-docal
kp-juan-docal previously approved these changes Nov 8, 2023
Copy link
Contributor

@kp-juan-docal kp-juan-docal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor question. LGTM!

Package.swift Show resolved Hide resolved
@kp-said-rehouni kp-said-rehouni force-pushed the PIA-675_tvOS_compatibility branch 2 times, most recently from 884318a to cdea8ac Compare November 8, 2023 07:19
kp-juan-docal
kp-juan-docal previously approved these changes Nov 8, 2023
@kp-juan-docal
Copy link
Contributor

@kp-said-rehouni we are bringing over 121 commits that are not necessarily about TV compatibility. Is that intentional?

Copy link
Collaborator

@kp-laura-sempere kp-laura-sempere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! 👍

@kp-said-rehouni kp-said-rehouni force-pushed the PIA-675_tvOS_compatibility branch from c504d50 to 428efa0 Compare November 21, 2023 10:05
@kp-said-rehouni kp-said-rehouni dismissed kp-laura-sempere’s stale review November 21, 2023 12:43

The merge-base changed after approval.

@kp-said-rehouni kp-said-rehouni force-pushed the PIA-675_tvOS_compatibility branch from 2b7331c to 88dd24a Compare November 21, 2023 17:31
Copy link
Collaborator

@kp-laura-sempere kp-laura-sempere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job 🚀

@kp-said-rehouni kp-said-rehouni merged commit a0f5bd5 into master Nov 22, 2023
1 check passed
@kp-said-rehouni kp-said-rehouni deleted the PIA-675_tvOS_compatibility branch November 22, 2023 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants