prototype Pydantic choice support in create_pydantic_model
#469
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #467
Just a prototype at the moment.
If a Piccolo column has choices, we can use the choices
Enum
as the Pydantic type. For example:It would become this Pydantic model:
The problem is the JSON schema it generates is quite complex, and Piccolo Admin doesn't currently understand
$ref
values:So the options are:
$ref
PydanticModel
class #331, which would add a new API for creating Pydantic models.create_pydantic_model
will still be supported, and used by Piccolo admin for now, but we can migrate to this new API at a later date.