This repository has been archived by the owner on Jun 5, 2019. It is now read-only.
SECURITY-786 Improve Memory Performance #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We did some profiling of or JBoss AS instance and noticed that audit logging on JavaEE resources is causing most of our allocations outside [TLAB] [1] s. This was a bit surprising to use since we don't have audit logging on. We tracked them down to `org.jboss.security.javaee.AbstractJavaEEHelper.authorizationAudit` which unnecessarily does an eager string conversion of every `org.jboss.security.authorization.Resource`. This could be done lazily on demand when audit logging is on in `AuditEvent#toString`. Since the map is already of type `Map<String,Object>` simply removing the call to `#toString()` fixes this. * don't do eager string conversion of resources in `AbstractJavaEEHelper#authorizationAudit` [1]: http://openjdk.java.net/groups/hotspot/docs/HotSpotGlossary.html#TLAB Issue: SECURITY-786 https://issues.jboss.org/browse/SECURITY-786
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We did some profiling of or JBoss AS instance and noticed that audit
logging on JavaEE resources is causing most of our allocations outside
TLAB s. This was a bit surprising to use since we don't have audit
logging on. We tracked them down to
org.jboss.security.javaee.AbstractJavaEEHelper.authorizationAuditwhich unnecessarily does an eager string conversion of every
org.jboss.security.authorization.Resource. This could be done lazilyon demand when audit logging is on in
AuditEvent#toString. Since themap is already of type
Map<String,Object>simply removing thecall to
#toString()fixes this.AbstractJavaEEHelper#authorizationAuditIssue: SECURITY-786
https://issues.jboss.org/browse/SECURITY-786