Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Timer to Hide "You're Connected" Text #48

Merged
merged 2 commits into from
Dec 24, 2023

Conversation

agrim0312
Copy link
Contributor

@agrim0312 agrim0312 commented Dec 19, 2023

Description
fixed #39
Upon connecting to the Pieces OS, there is a need to enhance the user experience by implementing a timer that automatically hides the "You're Connected" text and shrinks the button after a certain duration.

This PR fixes #
Identify the element containing the "You're Connected" text and the associated button.
Implement a timer function in the relevant JavaScript file.
Upon connection, trigger the timer to start.
After the specified duration, hide the text and apply the button shrink effect.

Copy link
Contributor

@shivay-at-pieces shivay-at-pieces left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, only point is that the animation can be a bit smoother.

@shivay-at-pieces
Copy link
Contributor

cc @jordan-pieces

Copy link
Contributor

@jwafu jwafu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good @agrim0312 - @shivay-at-pieces your correct we can clean up the animation here but lets just get a related issue created to come back to this now that we have an initial implementation of it! 👍

@jwafu jwafu merged commit b703f12 into pieces-app:main Dec 24, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Timer to Hide "You're Connected" Text
3 participants