Conversation
|
Nice!! Love the fact that there's variables to control the lib/ubuntu version. Thanks for the PR @pfxuan ! |
|
@pierotofy Thank you for your help and support. Looking forward to see the next move for ODM + OpenSplat. |
|
I tried the ROCm dockerfile through The README doesn't really say anything after running the setup of how to run through Docker. Is there anything special for that? EDIT: Gist https://gist.github.com/parkerlreed/f123f824bd436c2989b1d00a04c12ed5 |
|
I think the Dockerfile.rocm file is missing the build commands (everything else should be there though). https://github.com/pierotofy/OpenSplat/blob/main/Dockerfile#L46 vs. https://github.com/pierotofy/OpenSplat/blob/main/Dockerfile.rocm#L70 @pfxuan might have more insights. |
|
Good catch. Dockerfile.rocm includes the full version of ROCm/HIP build environment but is missing the actual compile and build part. It should be very similar to this step. I'll probably add it from the next PR with an extra ROCm 6.0.2 support: |
This PR reuses the existing ubuntu CI build logic to build local or remote docker images across different setup.