Merge pull request #803 from aurianer/release_notes_0_19_1

Add release notes for pika patch release 0.19.1
pika-org · Oct 9, 2023 · a3e0bee · a3e0bee
2 parents 2275822 + 9bda172
commit a3e0bee
Show file tree

Hide file tree

Showing 5 changed files with 29 additions and 7 deletions.
diff --git a/.gitlab/pipeline.yml b/.gitlab/pipeline.yml
@@ -36,16 +36,18 @@ clang14_debug_build:
 
 .test_common_mc:
   stage: test
-  extends: .test_common
-  extends: .container-runner-daint-mc
+  extends:
+    - .test_common
+    - .container-runner-daint-mc
   variables:
     SLURM_CONSTRAINT: mc
     SLURM_PARTITION: normal
     PROCESSOR_COUNT: 36
 
 .test_common_gpu:
-  extends: .test_common
-  extends: .container-runner-daint-gpu
+  extends:
+    - .test_common
+    - .container-runner-daint-gpu
   variables:
     SLURM_CONSTRAINT: gpu
     SLURM_PARTITION: normal

diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -4,6 +4,12 @@
 <!--- Distributed under the Boost Software License, Version 1.0. (See accompanying -->
 <!--- file LICENSE_1_0.txt or copy at http://www.boost.org/LICENSE_1_0.txt) -->
 
+## 0.19.1 (2023-10-09)
+
+### Bugfixes
+
+- Fix a bug in `drop_operation_state` when the predecessor sender is sending a tuple. ([#801](https://github.com/pika-org/pika/pull/801))
+
 ## 0.19.0 (2023-10-04)
 
 ### New features

diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -50,8 +50,8 @@ set_property(GLOBAL PROPERTY USE_FOLDERS ON)
 # ##############################################################################
 set(PIKA_VERSION_MAJOR 0)
 set(PIKA_VERSION_MINOR 19)
-set(PIKA_VERSION_PATCH 0)
-set(PIKA_VERSION_DATE 20231004)
+set(PIKA_VERSION_PATCH 1)
+set(PIKA_VERSION_DATE 20231009)
 set(PIKA_VERSION_TAG "")
 
 set(PIKA_VERSION

diff --git a/libs/pika/execution/include/pika/execution/algorithms/drop_operation_state.hpp b/libs/pika/execution/include/pika/execution/algorithms/drop_operation_state.hpp
@@ -87,7 +87,7 @@ namespace pika::drop_op_state_detail {
 
             try
             {
-                auto ts_local = std::tuple(PIKA_FORWARD(Ts, ts)...);
+                std::tuple<std::decay_t<Ts>...> ts_local(PIKA_FORWARD(Ts, ts)...);
                 r.op_state->op_state.reset();
 
                 std::apply(pika::util::detail::bind_front(pika::execution::experimental::set_value,

diff --git a/libs/pika/execution/tests/unit/algorithm_drop_operation_state.cpp b/libs/pika/execution/tests/unit/algorithm_drop_operation_state.cpp
@@ -14,6 +14,7 @@
 #include <memory>
 #include <stdexcept>
 #include <string>
+#include <tuple>
 #include <type_traits>
 #include <utility>
 
@@ -107,6 +108,19 @@ int main()
         PIKA_TEST(set_value_called);
     }
 
+    {
+        std::atomic<bool> set_value_called{false};
+        auto s = ex::just(std::tuple<int, std::string>(42, "hello")) | ex::drop_operation_state();
+        constexpr auto f = [](std::tuple<int, std::string>&& t) {
+            PIKA_TEST_EQ(std::get<int>(t), 42);
+            PIKA_TEST_EQ(std::get<std::string>(t), std::string("hello"));
+        };
+        auto r = callback_receiver<decltype(f)>{f, set_value_called};
+        auto os = ex::connect(std::move(s), std::move(r));
+        ex::start(os);
+        PIKA_TEST(set_value_called);
+    }
+
     // Test that operation state is actually dropped
     {
         auto sp = std::make_shared<int>(42);