Remove PIKA_MOVE
and PIKA_FORWARD
#1325
Draft
+932
−971
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The macros were originally introduced to avoid the template instantiation overhead of
std::move
andstd::forward
, as well as the debug bloat. Both clang and GCC should nowadays treat them as builtins, though perhaps not on all supported compiler versions. Since the original change was simply a build-time optimization I think it's fair to go back to thestd::
functions again.The benefit is that tooling like clang-tidy can warn about improper uses of the functions.
The one downside of using
std::move
overPIKA_MOVE
(which is simply a cast to a non-const r-value reference) is thatstd::move
will happily createconst&&
types, where that is almost never intended for a move.