fix(shapes): fix adding shapes to collection

pikasojs · Feb 21, 2023 · 61aa922 · 61aa922
1 parent 53736b7
commit 61aa922
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 2 deletions.
diff --git a/src/Background/index.ts b/src/Background/index.ts
@@ -40,11 +40,13 @@ export class Background {
     const overlay = new Konva.Rect()
 
     this.image = new ImageModel(board, image, {
+      internal: true,
       selectable: false,
       history: false
     })
 
     this.overlay = new RectModel(board, overlay, {
+      internal: true,
       selectable: false,
       history: false
     })

diff --git a/src/shape/ShapeModel/index.ts b/src/shape/ShapeModel/index.ts
@@ -75,23 +75,29 @@ export abstract class ShapeModel<
 
     this.config = {
       transformer: {},
+      internal: false,
+      history: true,
+      selectable: true,
       ...config
     }
 
-    if (config.history ?? true) {
+    if (this.config.history) {
       this.board.history.create(this.board.layer, [], {
         undo: () => this.delete(),
         redo: () => this.undelete()
       })
     }
 
+    if (this.config.internal === false) {
+      this.board.addShape(this)
+    }
+
     this.board.events.emit('shape:create', {
       shapes: [this]
     })
 
     if (this.selectable) {
       this.node.draggable(true)
-      this.board.addShape(this)
     }
 
     this.board.layer.add(this.node)

diff --git a/src/types/shapes.ts b/src/types/shapes.ts
@@ -37,6 +37,7 @@ export declare interface ShapeConfig {
   transformer?: Konva.TransformerConfig
   selectable?: boolean
   history?: boolean
+  internal?: boolean
 }
 
 export declare interface LabelConfig extends ShapeConfig {