Open
Conversation
will translate these urls into filesystem paths, which then can be minified
Owner
|
Very cool idea. Thanks a lot. I added a few comments to one of the commits and I would love if you could take the time to maybe have a look at it. Also, is this enough? When you have a static.example.com, then smarty's way of just emitting a path relative to the current host won't be enough - at least you'd use the main advantage of a static.-domain (no cookies being sent). IMHO, this also (and maybe you can get away with only instead of also) a way to tell sacy to prefix the emitted URL with a different host. so something like define('SACY_STATIC_HOST_PREFIX', 'http://static.example.com/');which would then have sacy generate <script src="http://static.example.com/assets/many-files-344deadbeef.js"></script>instead of just <script src="/assets/many-files-344deadbeef.js"></script>I'm about to need something like this anyways in my setup. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a setting that allows to define a mapping of urls to file system paths