Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop #56

Draft
wants to merge 5 commits into
base: 2.x
Choose a base branch
from
Draft

Develop #56

wants to merge 5 commits into from

Conversation

wesleytodd
Copy link
Member

No description provided.

@wesleytodd wesleytodd changed the base branch from master to 2.x August 31, 2024 19:15
@wesleytodd wesleytodd force-pushed the 2.x branch 2 times, most recently from 2afa91a to c45583d Compare September 2, 2024 18:28
@wesleytodd
Copy link
Member Author

@Phillip9587 @UlisesGascon I had opened this to make sure we didn't loose @dougwilson's work on this. I forgot about it until just now and realized maybe we could land some of this? Can y'all take a look and share your opinion on it?

@Phillip9587
Copy link
Contributor

@wesleytodd Introducing the text/plain fallback response is a non-breaking change that can be integrated into the current v2 release line. However, adding the new message and stacktrace options while removing the existing env option is a breaking change in the current state, as it modifies the current options interface and could affect users relying on the env setting.

I suggest splitting the pull request into two separate ones to keep reviews focused:​

  • One PR focusing on the text/plain fallback response.

  • Another PR introducing the message and stacktrace options and deprecating the env option.

I will split them up and open 2 PRs so we can keep reviewing on the individual changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants