Repository navigation
Sync 5.0 with the 4.4.0 release and flip security defaults - #286
Merged
Merged
Conversation
UlisesGascon
marked this pull request as ready for review
October 15, 2026 10:15
bjohansebas
approved these changes
Oct 15, 2026
mfdebian
approved these changes
Nov 4, 2026
mfdebian
left a comment
Contributor
There was a problem hiding this comment.
Just some nitpicking comments tbh, but otherwise it LGTM!
This PR does need rebasing now though, so it can land safely!
Thank you @UlisesGascon!
allowProtoMethodsByDefault and allowProtoPropertiesByDefault now default to false (handlebars' safe defaults); opt back in via the runtimeOptions instance option. Includes the 5.0.0 HISTORY entry and the GHSA-3c55 async-escaping regression test. BREAKING CHANGE: inherited (prototype) members of the data are no longer readable from templates by default. Set allowProtoMethodsByDefault and/or allowProtoPropertiesByDefault to true via runtimeOptions to restore the previous behavior.
Build the runtime options object on a null prototype and stop setting allowProtoMethodsByDefault / allowProtoPropertiesByDefault explicitly. Blocked lookups now log handlebars' warning, and options can no longer be inherited from Object.prototype.
UlisesGascon
force-pushed
the
feat/5.0-options-secure-defaults
branch
from
November 13, 2026 14:11
acce2c3 to
24e3bb5
Compare
mfdebian
approved these changes
Nov 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings the
5.0branch in line with the latest 4.x release (#285) and ships the breaking security-defaults change that 5.0 exists for. The two lines diverged a while ago, so 5.0 was missing the recent 4.x work.What this does
compileOptionsinstance option (#268)runtimeOptionsinstance option (#284)allowProtoMethodsByDefaultandallowProtoPropertiesByDefaulttofalse(handlebars' safe defaults)HISTORY.mdwith the 4.2.1 / 4.3.0 / 4.3.1 / 4.4.0 entries and add a5.0.0entryBreaking change
Inherited (prototype) members of the data are no longer readable from templates by default. Apps that need prototype access opt back in per instance:
Notes
package.jsonversion is intentionally left at4.2.0; the5.0.0bump belongs to the release step.