Repository navigation
Migrate test runner from vitest to mocha (simplify tooling, enable 18.0.0 floor) - #290
Merged
Merged
Conversation
Replace the vitest runner with mocha 10 so the suite runs across the full Node 18 range, including the 18.0.0 floor that vite could not load. Convert the test files to mocha globals and node:assert, drop coverage and the coveralls integration, and remove the vitest/vite devDependencies.
bjohansebas
approved these changes
Oct 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simplifies the test tooling and lets CI actually exercise the Node 18.0.0 floor.
{ constants }fromnode:fs/promises, which only exists from Node 18.4, so vitest could never load on the declared 18.0 floor. mocha 10 supports Node >= 14, so the suite now runs across the full 18.x range.vitest,@vitest/coverage-v8, theviteoverride,vitest.config.mjs, and the coveralls coverage integration. Addsmocha. Net devDependencies go from 7 to 6, and vite's large transitive tree is gone.node:assert(no test logic changed) and updates the eslint test globals.18.0.0CI leg (every leg runs plainnpm test); lint stays on Node >= 22.Coverage is dropped: there is no zero-dependency coverage path for mocha, so keeping it would mean adding c8 or nyc. It can be reintroduced later (c8 on the latest Node leg only) if wanted.