Dependencies: parseurl@^1.3.3#132
Closed
yatiac wants to merge 1 commit intopillarjs:masterfrom
Closed
Conversation
Alexispoveda
approved these changes
Oct 25, 2024
bjohansebas
approved these changes
Oct 25, 2024
UlisesGascon
approved these changes
Oct 26, 2024
wesleytodd
approved these changes
Mar 5, 2025
Member
|
WOAH! I cannot believe this happened, but look at the time stamps on this: #133 Really sorry to have left this, then to approve it and not realize it was opened literally within 1 minute of the one I opened. I am almost considering doing some git magic to add you as co-author on that one which landed. I really prefer to take contributions from outside contributors over ones from ourselves, and had I seen gone through all the open issues for this I would have merged yours instead. As it stands, I will close this but know that we appreciate the work and really didn't intend for this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference: expressjs/discussions#290
Dependencies:
parseurl@^1.3.3