deps: ispromise@^4.0.0#135
Merged
wesleytodd merged 1 commit intopillarjs:masterfrom Feb 10, 2025
Merged
Conversation
bjohansebas
approved these changes
Oct 25, 2024
UlisesGascon
approved these changes
Oct 26, 2024
Merged
wesleytodd
approved these changes
Feb 10, 2025
wesleytodd
reviewed
Feb 10, 2025
| - Drop support for partial capture group `router.route('/user(s?)/:user/:op')` but still have optional non-capture `/user{s}/:user/:op` | ||
| - `:name?` becomes `{:name}` | ||
| - `:name*` becomes `*name`. | ||
| - `:name*` becomes `*name`. |
Member
There was a problem hiding this comment.
My editor removed the trailing white space here while rebasing. While it was not in the original change I think it is alright to keep.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The dependency was updated according to this expressjs/discussions#290