CI: Rewrite set_image for Spectra 6 to handle more edge cases #228
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've had various problems with the image remapping code (particularly where P mode images have more than six colours), most of which was very, very old code I wrote back when I had much less idea what I was doing.
This rewrite should fix all cases by avoiding as much special casing as possible. The one exception is where a P mode image has no palette at all, and thus no colour information. For example the Hello World example uses palette indexes but never creates a palette (
image.palette.colors == {}
) so attempting to quantize it has very bizarre results.