Force -Wall & -Werror, fix build warnings #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 to -Werror. |
|
So.. should we perhaps get #33 merged and then only merge my Werror/Wall enablement commit so that it builds properly? |
|
Yes. Id hope that after committing the first that very little of the second
remains. (I think I saw you fix an additional data type to avoid a cast in
DAC or something...)
It's been held "for testing" without definition of what that testing is.
They're static functions that have no callers. They were seemingly left
after a copy/paste with the callers removed. Since they're static, they're
known to not have callers. I don't know why these are stuck.
My hardware arrived just yesterday, but there's no working flash tool for
MacOS yet. It's not clear what the required acceptance test is as I don't
think we have a test suite...
…On Tue, Dec 1, 2020, 12:22 PM Konrad Dybcio ***@***.***> wrote:
So.. should we perhaps get #33
<#33> merged and *then* only
merge my Werror/Wall enablement commit so that it builds properly?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#82 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACCSD3YYNI2UJWAYGIC5RSDSSUX4PANCNFSM4UIHNLFA>
.
|
|
(bump) |
Signed-off-by: Konrad Dybcio <[email protected]>
added 2 commits
January 15, 2021 20:29
Signed-off-by: Konrad Dybcio <[email protected]>
Signed-off-by: Konrad Dybcio <[email protected]>
|
(bump?) |
|
Thank you very much for your pull request! |
tchebb
added a commit
to tchebb/bl_iot_sdk
that referenced
this pull request
Mar 15, 2023
…CXX code." In the Pine64 fork, we previously added -Wall and -Werror to the end of CFLAGS and CXXFLAGS (pine64#82). Those flags are desirable, but they're already present in both those variables from the earlier expansion of COMMON_WARNING_FLAGS. As such, the only purpose the added copies served was to re-enable any warnings that the intervening flags disabled--for example, ones disabled by an individual project's local flags. With the new upstream merge, our added flags broke the build for some such projects whose code triggers warnings. Although ideally we should fix those projects, I don't think a blanket force-enablement like this is the right way to do that: the flags are already enabled by default, so there's likely a good reason for a project to explicitly opt out of certain warnings. Instead of ignoring those opt-outs, we should just try to fix them as time permits: they're easy to find by grepping for -Wno in project Makefiles. If we keep these flags, we force anyone who does an upstream merge to synchronously fix a bunch of modules before they can push that merge. I think that's an unreasonable thing to ask given the quantity of code in this SDK. This reverts commit f745f48.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.