Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing simpleicons-based windows logo by standalone version #73

Merged
merged 3 commits into from
Jan 10, 2025

Conversation

ia
Copy link
Contributor

@ia ia commented Jan 9, 2025

TO: @Ralim
CC: @gamelaster

TL;DR: for some reason since Window logo did disappear from simpleicons.org database, the easiest and the simplest way seems to just replace it with the local version for the table of supported devices.

Currently vs Patched.

It's strange but you can't find any windows nor microsoft related icons through simpleicons anymore. I did try to utilize svg version from fontawesome, like this:

<svg width=16 viewBox="0 0 448 512"><path fill="#5791ac" d="M0 93.7l183.6-25.3v177.4H0V93.7zm0 324.6l183.6 25.3V268.4H0v149.9zm203.8 28L448 480V268.4H203.8v177.9zm0-380.6v180.1H448V32L203.8 65.7z"/></svg>

But this doesn't work with GitHub'based Markdown flavor (for security reasons to avoid malicious payloads and/or content from 3rd party sources which may be compromised, as far as I could understand).

So the straightforward option is to:

  • tune the color for svg version of fontawesome;
  • download svg;
  • convert it to png;
  • upload to img/;
  • use it as local img src=img/....

Hence, here is the suggestion in this patch.

For the record, due to such kind of exact nuances I'm not a big fan myself of turning markdown files into html much (because the whole idea of markdown is not to be html much). But since there is a nicely done table already, this is a proposal fix for the broken window logo (sweet irony, punch intended :)

Let me know what you think.

Copy link
Collaborator

@Ralim Ralim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree the simplest is to just have it in the repo in this case.

@Ralim Ralim merged commit a7f857e into pine64:master Jan 10, 2025
8 checks passed
@ia ia deleted the readme-icons branch February 7, 2025 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants