Markdown/RST needs to be recolored? Spec defined for it? Other?

[bigpick]

Info

Mirroring issue into the main source repo, for thoughts/tracking here.

See: bigpick/spaceduck-atom-syntax#2

[jinh0]

It does seem like there's a lot of work to be done with Markdown, especially since it's such a frequently-used language.

The markdown file in Vim doesn't look right either, (URL's being yellow). No wonder: there isn't any code for Markdown syntax highlighting in colors/spaceduck.vim.

One thing, though: syntax highlighting for Markdown looks more accurate with vim-polyglot since it comes with highlights as well.

On first glance, I don't think there will be a problem making highlights for Vim without polyglot and for polyglot users since polyglot uses mkd prefixed syntax groups while Vim defaults with markdown prefixed syntax groups.

I like your interpretation of the colors for the Atom syntax, but maybe the ** in BOLD TEXT can be SpaceduckMagenta?
I think the link text in LINK TEXT could be SpaceduckGreen like in Vim as to distinguish it from the URL.
What about changing the bullet points / numbering as a different color, maybe SpaceduckMagenta? My interpretation is that cyan should be reserved to less important strings like a link's URL.
Also, I would avoid using SpaceduckOrange like for bold text until @pineapplegiant fixes it.
Let me know what you think.

[bigpick]

I'd be done for all that, no problem.

Though I think adding in some of the markdown fields/qualifiers to the spec would be a good idea too as a result of this work.

[bigpick]

maybe the ** in BOLD TEXT can be SpaceduckMagenta?

done

the link text in LINK TEXT could be SpaceduckGreen

done

changing the bullet points / numbering as a different color, maybe SpaceduckMagenta? My interpretation is that cyan should be reserved to less important strings like a link's URL

I trued magenta, but I think personally dark-purple2 looks best; imo, I think keeping it mostly purple/shades of the purple with occasional pops of color for accents is better than trying to sprinkle the colors throughout everything.

Also, I would avoid using SpaceduckOrange like for bold text until @pineapplegiant fixes it.

I'm talked briefly about some of the changes they are looking to make, and am ok with making things now, and coming back in later to update them with new colors/spec'ed colors.

---

For reference, here's what it looks like now with the above updates (and I switched over to the new cyan color from the dev branch, nice). I'm not sure how I feel about URLs/links being highlighted when they are in a comment (e.g line 3); I think it may look better if they were forced to be "unhighlighted" and just remain the same color as the comment, but am up for opinions?:

[bigpick]

wrt

I'm not sure how I feel about URLs/links being highlighted when they are in a comment (e.g line 3); I think it may look better if they were forced to be "unhighlighted" and just remain the same color as the comment, but am up for opinions?

I'm talking about basically whatever atom highlights as https://..... (not about the specific syntax).

To get what I was talking about, essentially have to force https things to just inherit their current color. For example, this is what it looks like instead (notice line 3 and line 36 have changed, but the markdown link syntax is still cyan):

Thoughts?

[pineapplegiant]

Gotta update the line numbers and comment colors too. Active text tab should be gray. Bold text should probably be yellow as well.

Apologies again, this isn’t written all up yet.

[bigpick]

Ah, yeah, I think I had issues opened for that already (line numbers) in my repo.

But you're saying the active tab up top text color Fg should be gray? Or something else?

• edit: ah, you're probably talking about the currently selected line's coloring/highlighting

And, comments I had made the comment color(?) Ah, I see, on the dev branch comments are a new dedicated color, #535f97

[bigpick]

• Updated line number coloring non-current line (dark-purple)
• Updated line number coloring current line (grey)
• Updated comment color to use new color from dev branch
• Change bold text to be yellow, not orange

I think I need to make tickets for myself to go update the atom UI, so that the tab coloring matches the gutter coloring (dark-purple in active, grey active, etc) as I think that'll look better than using FG on the tabs there too.