Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wip] unpatch threading for dataset downloading #223

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jonathanzxu
Copy link
Contributor

Problem

Tests were failing sometimes due to a "This operation would block forever" error from gevent.

Solution

We shouldn't call gevent functions in raw threads in the hub's ThreadPool, because they might not have Hubs and could throw. Instead reload the threading module to python's default, and re-patch on exit.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Infrastructure change (CI configs, etc)
  • Non-code change (docs, etc)
  • None of the above: (explain here)

Test Plan

Tests should pass

@jonathanzxu jonathanzxu changed the title Unpatch threading for dataset downloading [wip] unpatch threading for dataset downloading Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant