Generate code based on 2025-01 api spec #171
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhamon
approved these changes
Jan 10, 2025
austin-denoble
approved these changes
Jan 10, 2025
… the protos (#174) ## Problem The code generation using proto file was done using protoc and the process was manual. ## Solution Added a script to generate java classes using [buf](https://buf.build/docs/generate/overview/). ## Type of Change - [ ] Bug fix (non-breaking change which fixes an issue) - [X] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] This change requires a documentation update - [ ] Infrastructure change (CI configs, etc) - [ ] Non-code change (docs, etc) - [ ] None of the above: (explain here) ## Test Plan Integration tests should run successfully.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Generate code based on the 2025-01 api spec
Solution
The following changes have been made to ensure compatibility with the generated code using the 2025-01 API specification:
Map<String, Object>instead ofEmbedRequestParametersEmbeddingshas dense and sparse embeddings, so the integration test was updated to get dense embedding values:embeddings.getData().get(0).getValues().size()->embeddings.getData().get(0).getDenseEmbedding().getValues().size()List<Map<String, Object>>instead ofList<Map<String, String>>Map<String, Object>instead ofMap<String, String>Type of Change
Test Plan
Updated unit and integration tests