Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xindi/keyboard control #1

Merged
merged 3 commits into from
Jul 15, 2020
Merged

Xindi/keyboard control #1

merged 3 commits into from
Jul 15, 2020

Conversation

xindixu
Copy link

@xindixu xindixu commented Jul 15, 2020

Exactly the same as PR in original repo

Changes

Added keyboard control:

Category anchors:

ezgif com-video-to-gif (1)

  • When focusing on any emoji, Tab to change focus to the first category anchor
  • When a category is selected, Arrow Down to go to the first item in the category
  • This also means that when focusing on any emoji, Tab can no longer used to go to the next emoji
  • Same applies to search
    ezgif com-video-to-gif (2)

Emoji:

ezgif com-video-to-gif

  • Arrow Up, Arrow Down, Arrow Left, Arrow Right to go to emojis on top/down/left/right to the current emoji
  • Able to jump to next/previous category if at the last line/first row

Style:

  • emoji focus style now should look the same as emoji on hover style

Markup:

  • Change emoji layout to table/cell with a11y roles

References:

@xindixu xindixu merged commit 357ece2 into master Jul 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant