-
Notifications
You must be signed in to change notification settings - Fork 12
*: add concurrently processing for individual metrics and introduce some flags #475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
zimulala
wants to merge
7
commits into
pingcap:master
Choose a base branch
from
zimulala:zimuxia/conncurrency
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zimulala
commented
Apr 18, 2025
| cmd.Flags().StringSliceVar(&ext, "exclude", nil, "types of data not to collect") | ||
| cmd.Flags().StringSliceVar(&cOpt.MetricsFilter, "metricsfilter", nil, "prefix of metrics to collect") | ||
| cmd.Flags().StringSliceVar(&cOpt.MetricsExclude, "metricsexclude", []string{"node_interrupts_total"}, "prefix of metrics to exclude") | ||
| cmd.Flags().StringSliceVar(&cOpt.MetricsLowPriority, "metrics-low-priority", []string{"tidb_tikvclient_request_seconds_bucket"}, |
Contributor
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to be considered: whether to separate the data pulling of high-volume metrics from regular metrics by default.
180a406 to
4e78028
Compare
Contributor
Author
|
PTAL @XuHuaiyu |
2 similar comments
Contributor
Author
|
PTAL @XuHuaiyu |
Contributor
Author
|
PTAL @XuHuaiyu |
Contributor
Author
|
The static-tests issue will be fixed in #485 |
Contributor
Author
|
PTAL @XuHuaiyu |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
The current bottleneck in diag data pulling lies in the long export time or direct failure of metrics with the largest storage footprint.
What is changed and how it works?
Check List
Tests
Code changes
Side effects
Related changes