-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add new config hashagg_use_magic_hash for tiflash #19869
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: guo-shaoge <[email protected]>
tiflash/tiflash-configuration.md
Outdated
@@ -265,6 +265,11 @@ delta_index_cache_size = 0 | |||
## 从 v6.4.0 引入,用于 MinTSO 调度器,表示一个 TiFlash 实例中最多可同时运行的查询数量,默认值为 0,即两倍的 vCPU 数量。关于 MinTSO 调度器,详见 https://docs.pingcap.com/zh/tidb/dev/tiflash-mintso-scheduler | |||
task_scheduler_active_set_soft_limit = 0 | |||
|
|||
## 从 v9.1.0 引入,如果该配置为 true,TiFlash 的 HashAgg 会使用 magic hash 而非默认的 CRC32。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
## 从 v9.1.0 引入,如果该配置为 true,TiFlash 的 HashAgg 会使用 magic hash 而非默认的 CRC32。 | |
## 从 v9.0.0 引入,如果该配置为 true,TiFlash 的 HashAgg 会使用 magic hash 而非默认的 CRC32。 |
Signed-off-by: guo-shaoge <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@guo-shaoge: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@windtalker: adding LGTM is restricted to approvers and reviewers in OWNERS files. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
First-time contributors' checklist
What is changed, added or deleted? (Required)
Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions (in Chinese).
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?