Skip to content

*: update keyword auto_increment to CAPS#2181

Merged
toutdesuite merged 10 commits intopingcap:masterfrom
toutdesuite:update-keyword-auto_increment-to-CAPS
Jan 15, 2020
Merged

*: update keyword auto_increment to CAPS#2181
toutdesuite merged 10 commits intopingcap:masterfrom
toutdesuite:update-keyword-auto_increment-to-CAPS

Conversation

@toutdesuite
Copy link
Copy Markdown
Contributor

@toutdesuite toutdesuite commented Jan 14, 2020

What is changed, added or deleted?

AUTO_INCREMENT: update keyword auto_increment to CAPS

What is the related PR or file link(s)?

pingcap/docs#1750

Which version does your change affect?

ALL

@toutdesuite toutdesuite requested a review from yikeke January 14, 2020 03:19
@toutdesuite toutdesuite added the translation/from-docs This PR is translated from a PR in pingcap/docs. label Jan 14, 2020
@yikeke yikeke requested a review from csuzhangxc January 14, 2020 05:59
@yikeke
Copy link
Copy Markdown
Contributor

yikeke commented Jan 14, 2020

Please help review the changes in DM-related files, especially for auto_increment_id. @csuzhangxc
Rest LGTM

Copy link
Copy Markdown
Member

@csuzhangxc csuzhangxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest LGTM

Comment thread dev/how-to/get-started/data-migration.md Outdated
Comment thread dev/how-to/get-started/data-migration.md Outdated
Comment thread dev/reference/tools/data-migration/usage-scenarios/shard-merge.md Outdated
Comment thread dev/reference/tools/data-migration/usage-scenarios/shard-merge.md Outdated
Comment thread v2.1/how-to/get-started/data-migration.md Outdated
Comment thread v3.0/reference/tools/data-migration/usage-scenarios/shard-merge.md Outdated
Comment thread v3.1/how-to/get-started/data-migration.md Outdated
Comment thread v3.1/how-to/get-started/data-migration.md Outdated
Comment thread v3.1/reference/tools/data-migration/usage-scenarios/shard-merge.md Outdated
Comment thread v3.1/reference/tools/data-migration/usage-scenarios/shard-merge.md Outdated
Copy link
Copy Markdown
Member

@csuzhangxc csuzhangxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread dev/releases/21rc2.md Outdated
Comment thread v2.1-legacy/releases/21rc2.md Outdated
Comment thread v2.1/releases/21rc2.md Outdated
Comment thread v3.0/releases/21rc2.md Outdated
Comment thread v3.1/releases/21rc2.md Outdated
toutdesuite and others added 5 commits January 15, 2020 16:10
Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com>
Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com>
Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com>
Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com>
Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

@yikeke yikeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yikeke yikeke added the status/can-merge Indicates a PR has been approved by a committer. label Jan 15, 2020
@sre-bot
Copy link
Copy Markdown
Contributor

sre-bot commented Jan 15, 2020

/run-all-tests

@toutdesuite toutdesuite merged commit 0c8db9a into pingcap:master Jan 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status/can-merge Indicates a PR has been approved by a committer. translation/from-docs This PR is translated from a PR in pingcap/docs.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants