Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: update keyword auto_increment to CAPS #2181

Merged

Conversation

toutdesuite
Copy link
Contributor

@toutdesuite toutdesuite commented Jan 14, 2020

What is changed, added or deleted?

AUTO_INCREMENT: update keyword auto_increment to CAPS

What is the related PR or file link(s)?

pingcap/docs#1750

Which version does your change affect?

ALL

@toutdesuite toutdesuite requested a review from yikeke January 14, 2020 03:19
@toutdesuite toutdesuite added the translation/from-docs This PR is translated from a PR in pingcap/docs. label Jan 14, 2020
@yikeke yikeke requested a review from csuzhangxc January 14, 2020 05:59
@yikeke
Copy link
Contributor

yikeke commented Jan 14, 2020

Please help review the changes in DM-related files, especially for auto_increment_id. @csuzhangxc
Rest LGTM

Copy link
Member

@csuzhangxc csuzhangxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest LGTM

Copy link
Member

@csuzhangxc csuzhangxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@yikeke yikeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yikeke yikeke added the status/can-merge Indicates a PR has been approved by a committer. label Jan 15, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Jan 15, 2020

/run-all-tests

@toutdesuite toutdesuite merged commit 0c8db9a into pingcap:master Jan 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/can-merge Indicates a PR has been approved by a committer. translation/from-docs This PR is translated from a PR in pingcap/docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants