Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reference/tidb-binlog: add docs about relay log #2224

Merged
merged 27 commits into from
Feb 19, 2020
Merged

reference/tidb-binlog: add docs about relay log #2224

merged 27 commits into from
Feb 19, 2020

Conversation

july2993
Copy link
Contributor

@july2993 july2993 commented Feb 10, 2020 •
edited by lilin90
Loading

What is changed, added or deleted?

pingcap/tidb-binlog#883
add docs about relay log

What is the related PR or file link(s)?

pingcap/tidb-binlog#883

Which TiDB version(s) does your changes apply to?

dev

  • dev (the latest development version)

  • v3.0 (TiDB 3.0 versions)

  • v3.1 (TiDB 3.1 versions)

  • Updated one version first. Will update other versions after I get two LGTMs.

zier-one
zier-one reviewed Feb 10, 2020
View reviewed changes
dev/reference/tidb-binlog/deploy.md Outdated Show resolved Hide resolved
dev/reference/tidb-binlog/deploy.md Outdated Show resolved Hide resolved
dev/reference/tidb-binlog/deploy.md Outdated Show resolved Hide resolved
@IANTHEREAL
Copy link
Contributor

Rest LGTM

@july2993 july2993 mentioned this pull request Feb 12, 2020
Merged
@sre-bot sre-bot mentioned this pull request Feb 12, 2020
Merged
@zier-one
Copy link
Contributor

LGTM

@zier-one zier-one added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 13, 2020
suzaku
suzaku approved these changes Feb 13, 2020
View reviewed changes
Copy link
Contributor

@suzaku suzaku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@july2993
Copy link
Contributor Author

@TomShawn PTAL

@TomShawn
Copy link
Contributor

@july2993 LGTM. Please update all available versions.

@july2993
Copy link
Contributor Author

@july2993 LGTM. Please update all available versions.

done

TomShawn
TomShawn reviewed Feb 19, 2020
View reviewed changes
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

v3.1/reference/tidb-binlog/relay-log.md Outdated Show resolved Hide resolved
v3.0/reference/tidb-binlog/relay-log.md Outdated Show resolved Hide resolved
@july2993 july2993 requested a review from TomShawn February 19, 2020 09:28
TomShawn
TomShawn approved these changes Feb 19, 2020
View reviewed changes
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@july2993 july2993 merged commit 1eb8b15 into pingcap:master Feb 19, 2020
@WangXiangUSTC WangXiangUSTC mentioned this pull request Feb 26, 2020
Merged
This was referenced Feb 26, 2020
Merged
Merged
@ran-huang ran-huang added aligning and removed translation/doing This PR’s assignee is translating this PR. labels Feb 27, 2020
This was referenced Feb 27, 2020
Merged
Closed
Merged
@ran-huang ran-huang added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed aligning labels Feb 27, 2020
@lilin90 lilin90 added the requires-followup This PR requires a follow-up task after being merged. label Feb 27, 2020
@july2993 july2993 deleted the relay_doc branch March 4, 2020 07:11
@TomShawn TomShawn mentioned this pull request Mar 6, 2020
Merged
1 task
This was referenced Mar 13, 2020
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zier-one zier-one zier-one left review comments

@IANTHEREAL IANTHEREAL IANTHEREAL left review comments

@TomShawn TomShawn TomShawn approved these changes

@suzaku suzaku suzaku approved these changes

Assignees

@ran-huang ran-huang

Labels
requires-followup This PR requires a follow-up task after being merged. status/LGT1 Indicates that a PR has LGTM 1. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@july2993 @IANTHEREAL @zier-one @TomShawn @suzaku @lilin90 @ran-huang