Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tikv-config-file: update the default value of use-unified-pool #5537

Merged
merged 1 commit into from
Feb 18, 2021
Merged

tikv-config-file: update the default value of use-unified-pool #5537

merged 1 commit into from
Feb 18, 2021

Conversation

Joyinqin
Copy link
Contributor

First-time contributors' checklist

What is changed, added or deleted? (Required)

Update the default value of use-unified-pool from false to true.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@Joyinqin
Copy link
Contributor Author

/label needs-cherry-pick-5.0,size/small, translation/from-docs

@ti-srebot ti-srebot added needs-cherry-pick-5.0 size/small Changes of a small size. translation/from-docs This PR is translated from a PR in pingcap/docs. labels Feb 18, 2021
@Joyinqin
Copy link
Contributor Author

/cc TomShawn

@ti-srebot ti-srebot requested a review from TomShawn February 18, 2021 11:22
TomShawn
TomShawn approved these changes Feb 18, 2021
View reviewed changes
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 18, 2021
@TomShawn TomShawn merged commit 1fd8873 into pingcap:master Feb 18, 2021
ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Feb 18, 2021
@Joyinqin @ti-srebot
cherry pick pingcap#5537 to release-5.0
392c207 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Feb 18, 2021
Merged
11 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #5538

TomShawn pushed a commit that referenced this pull request Feb 18, 2021
@ti-srebot @Joyinqin
cherry pick #5537 to release-5.0 (#5538)
b622274 
Signed-off-by: ti-srebot <[email protected]>

Co-authored-by: JoyinQ <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomShawn TomShawn TomShawn approved these changes

Assignees
No one assigned
Labels
size/small Changes of a small size. status/LGT1 Indicates that a PR has LGTM 1. translation/from-docs This PR is translated from a PR in pingcap/docs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Joyinqin @ti-srebot @TomShawn