Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

master/5.0: remove low-version descriptions #5775

Merged
merged 11 commits into from
Apr 28, 2021
Merged

master/5.0: remove low-version descriptions #5775

merged 11 commits into from
Apr 28, 2021

Conversation

qiancai
Copy link
Collaborator

@qiancai qiancai commented Mar 19, 2021

First-time contributors' checklist

What is changed, added or deleted? (Required)

Removed the descriptions about the lower product versions according to the conclusion made in pingcap/docs#4549

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-srebot ti-srebot added the first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. label Mar 19, 2021
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 19, 2021
@qiancai
Copy link
Collaborator Author

qiancai commented Mar 19, 2021

/cc @yikeke @TomShawn

@ti-chi-bot ti-chi-bot requested review from TomShawn and yikeke March 19, 2021 03:37
@ti-chi-bot ti-chi-bot added needs-cherry-pick-5.0 v5.0 This PR/issue applies to TiDB v5.0 translation/doing This PR’s assignee is translating this PR. and removed missing-translation-status This PR does not have translation status info. labels Mar 19, 2021
@yikeke yikeke added v5.0 This PR/issue applies to TiDB v5.0 and removed v5.0 This PR/issue applies to TiDB v5.0 labels Mar 24, 2021
@ti-chi-bot ti-chi-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 1, 2021
@qiancai
Copy link
Collaborator Author

qiancai commented Apr 6, 2021

/hold

@ti-chi-bot ti-chi-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 6, 2021
@yikeke
Copy link
Contributor

yikeke commented Apr 7, 2021

/unhold

@ti-chi-bot ti-chi-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 7, 2021
@yikeke
Copy link
Contributor

yikeke commented Apr 7, 2021

/rebase

@github-actions github-actions bot force-pushed the Remove-legacy-version-specific-information branch from 21096e0 to 05fc1a7 Compare April 7, 2021 12:26
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 27, 2021
@TomShawn
Copy link
Contributor

/lgtm

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn
  • yikeke

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 28, 2021
@TomShawn
Copy link
Contributor

/assign Joyinqin

@TomShawn
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: cfd36d9

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 28, 2021
@ti-chi-bot ti-chi-bot merged commit 0011c80 into pingcap:master Apr 28, 2021
ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Apr 28, 2021
@qiancai @ti-srebot
cherry pick pingcap#5775 to release-5.0
2386287 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Apr 28, 2021
Merged
11 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #6189

ti-chi-bot pushed a commit that referenced this pull request Apr 28, 2021
@ti-srebot
master/5.0: remove low-version descriptions (#5775) (#6189)
b8ef14c
@Joyinqin Joyinqin mentioned this pull request Apr 29, 2021
Merged
11 tasks
@Joyinqin
Copy link
Contributor

/translation done
/remove-translation doing

@ti-chi-bot ti-chi-bot added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Apr 29, 2021
@ti-srebot ti-srebot mentioned this pull request Apr 29, 2021
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yikeke yikeke yikeke approved these changes

@TomShawn TomShawn Awaiting requested review from TomShawn

Assignees

@Joyinqin Joyinqin

Labels
first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. v5.0 This PR/issue applies to TiDB v5.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@qiancai @yikeke @TomShawn @ti-chi-bot @ti-srebot @Joyinqin