Skip to content

Update SQL Keywords and Reserved Words to CAPS #6421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 9, 2021
Merged

Update SQL Keywords and Reserved Words to CAPS #6421

merged 1 commit into from
Jun 9, 2021

Conversation

imp2002
Copy link
Contributor

@imp2002 imp2002 commented Jun 8, 2021 •
edited by TomShawn
Loading

First-time contributors' checklist

What is changed, added or deleted? (Required)

Update SQL Keywords and Reserved Words to CAPS

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot requested a review from TomShawn June 8, 2021 12:09
@ti-chi-bot ti-chi-bot added contribution This PR is from a community contributor. first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. labels Jun 8, 2021
@ti-chi-bot
Copy link
Member

Welcome @imp2002!

It looks like this is your first PR to pingcap/docs-cn 🎉.

I'm the bot to help you request reviewers, add labels and more, See available commands.

We want to make sure your contribution gets all the attention it needs!



Thank you, and welcome to pingcap/docs-cn. 😃

@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 8, 2021
TomShawn
TomShawn approved these changes Jun 8, 2021
View reviewed changes
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 8, 2021
@TomShawn TomShawn added needs-cherry-pick-release-4.0 translation/welcome Waits for a contributor to translate this PR and create a PR to the pingcap/docs-cn repository. labels Jun 8, 2021
@ti-chi-bot ti-chi-bot removed the missing-translation-status This PR does not have translation status info. label Jun 8, 2021
@TomShawn TomShawn added the require-LGT1 Indicates that the PR requires an LGTM. label Jun 8, 2021
@ti-chi-bot
Copy link
Member

@imp2002: The label(s) needs-cherry-pick-release-master cannot be applied. These labels are supported: Hacktoberfest, contribution, first-time-contributor, requires-followup, good-first-issue, hacktoberfest-accepted, help-wanted, needs-cherry-pick-release-2.1, needs-cherry-pick-release-3.0, needs-cherry-pick-release-3.1, needs-cherry-pick-release-4.0, needs-cherry-pick-release-5.0, needs-cherry-pick-master, question, require-LGT1, require-LGT2, require-LGT3, special-week, v4.0, v5.0, v5.1, for-future-release, requires-version-specific-changes, website.

In response to this:

/label needs-cherry-pick-release-master
/label needs-cherry-pick-release-5.0
/label needs-cherry-pick-release-4.0
/label needs-cherry-pick-release-3.1
/label needs-cherry-pick-release-3.0
/label needs-cherry-pick-release-2.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

1 similar comment
@ti-chi-bot
Copy link
Member

@imp2002: The label(s) needs-cherry-pick-release-master cannot be applied. These labels are supported: Hacktoberfest, contribution, first-time-contributor, requires-followup, good-first-issue, hacktoberfest-accepted, help-wanted, needs-cherry-pick-release-2.1, needs-cherry-pick-release-3.0, needs-cherry-pick-release-3.1, needs-cherry-pick-release-4.0, needs-cherry-pick-release-5.0, needs-cherry-pick-master, question, require-LGT1, require-LGT2, require-LGT3, special-week, v4.0, v5.0, v5.1, for-future-release, requires-version-specific-changes, website.

In response to this:

/label needs-cherry-pick-release-master
/label needs-cherry-pick-release-5.0
/label needs-cherry-pick-release-4.0
/label needs-cherry-pick-release-3.1
/label needs-cherry-pick-release-3.0
/label needs-cherry-pick-release-2.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@imp2002
Copy link
Contributor Author

imp2002 commented Jun 8, 2021

@TomShawn 您好, 5.0, 4.0是学bot再开两个pr分别合到对应分支对吗(´･ω･`)?

@imp2002 imp2002 mentioned this pull request Jun 8, 2021
Closed
11 tasks
@TomShawn
Copy link
Contributor

TomShawn commented Jun 9, 2021

@TomShawn 您好, 5.0, 4.0是学bot再开两个pr分别合到对应分支对吗(´･ω･`)?

谢谢您参与 TiDB 文档！不需要的单独给 5.0 和 4.0 提 PR。这个 PR 合并后，bot 会自动在 5.0 和 4.0 分支生成 PR 的。

@TomShawn
Copy link
Contributor

TomShawn commented Jun 9, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 09f07d7

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 9, 2021
@ti-chi-bot ti-chi-bot merged commit ba50d90 into pingcap:master Jun 9, 2021
@ti-chi-bot ti-chi-bot mentioned this pull request Jun 9, 2021
Merged
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #6423.

@ti-chi-bot ti-chi-bot mentioned this pull request Jun 9, 2021
Merged
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #6424.

ti-chi-bot added a commit that referenced this pull request Jun 9, 2021
@ti-chi-bot
Update SQL Keywords and Reserved Words to CAPS (#6421) (#6423)
dbaec7c
ti-chi-bot added a commit that referenced this pull request Jun 9, 2021
@ti-chi-bot
Update SQL Keywords and Reserved Words to CAPS (#6421) (#6424)
5b30ced
@chunleiz
Copy link
Contributor

/assign

@chunleiz
Copy link
Contributor

/remove-translation welcome

@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. and removed translation/welcome Waits for a contributor to translate this PR and create a PR to the pingcap/docs-cn repository. labels Oct 29, 2021
@chunleiz
Copy link
Contributor

/translation doing

@ti-chi-bot ti-chi-bot added translation/doing This PR’s assignee is translating this PR. and removed missing-translation-status This PR does not have translation status info. labels Oct 29, 2021
@Oreoxmt Oreoxmt self-assigned this Apr 6, 2022
@Oreoxmt Oreoxmt added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Apr 6, 2022
@Oreoxmt Oreoxmt mentioned this pull request Apr 6, 2022
Merged
15 tasks
This was referenced Apr 7, 2022
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomShawn TomShawn TomShawn approved these changes

Assignees

@chunleiz chunleiz

@Oreoxmt Oreoxmt

Labels
contribution This PR is from a community contributor. first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. require-LGT1 Indicates that the PR requires an LGTM. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@imp2002 @ti-chi-bot @TomShawn @chunleiz @Oreoxmt @Liuxiaozhen12