Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TiKV: add quota limiter doc in config #8648

Merged
merged 11 commits into from
Mar 25, 2022
Merged

TiKV: add quota limiter doc in config #8648

merged 11 commits into from
Mar 25, 2022

Conversation

hunterlxt
Copy link
Contributor

Signed-off-by: Xintao [email protected]

First-time contributors' checklist

What is changed, added or deleted? (Required)

Add TiKV quota related config doc.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v6.0 (TiDB 6.0 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@hunterlxt
Quota limiter
192206c 
Signed-off-by: Xintao <[email protected]>
@hunterlxt hunterlxt requested a review from en-jin19 March 14, 2022 09:31
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 14, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • en-jin19

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@hunterlxt hunterlxt self-assigned this Mar 14, 2022
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 14, 2022
@hunterlxt
fix
e8695f4 
Signed-off-by: Xintao <[email protected]>
@hunterlxt
fix
1ded777 
Signed-off-by: Xintao <[email protected]>
@hunterlxt
Copy link
Contributor Author

@en-jin19 PTAL

@en-jin19 en-jin19 self-assigned this Mar 14, 2022
@en-jin19
Copy link
Contributor

@hunterlxt Could you please invite a tech reviewer? thank you!

@en-jin19 en-jin19 added translation/doing This PR’s assignee is translating this PR. area/engine Indicates that the Issue or PR belongs to the area of TP storage or Cloud storage. v6.0 This PR/issue applies to TiDB v6.0. labels Mar 14, 2022
@ti-chi-bot ti-chi-bot removed the missing-translation-status This PR does not have translation status info. label Mar 14, 2022
@en-jin19 en-jin19 requested a review from easonn7 March 14, 2022 13:58
@en-jin19 en-jin19 added the type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. label Mar 14, 2022
@hunterlxt hunterlxt requested a review from tonyxuqqi March 14, 2022 13:58
@hunterlxt
Copy link
Contributor Author

PTAL @tonyxuqqi

@en-jin19 en-jin19 added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Mar 15, 2022
hunterlxt and others added 2 commits March 15, 2022 21:38
@ti-chi-bot ti-chi-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 15, 2022
@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 23, 2022
TomShawn
TomShawn reviewed Mar 24, 2022
View reviewed changes
tikv-configuration-file.md Outdated
> - 前台限流是 TiDB 在 v6.0 中引入的实验特性，不建议在生产环境中使用。
> - 该功能适合在资源有限的环境中（如 4vCPU，16G 内存）提高长期运行的稳定性，但启用该功能则会在资源丰富的机型环境出现 TiKV 峰值性能下降的情况。

### `foreground-cpu-time` <span class="version-mark">从 v6.0 版本开始引入</span>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@en-jin19 前端不支持 <span class="version-mark"> 的锚点链接

Suggested change
### `foreground-cpu-time` <span class="version-mark">从 v6.0 版本开始引入</span>
### `foreground-cpu-time`（从 v6.0 版本开始引入）

@en-jin19 en-jin19 removed the request for review from easonn7 March 24, 2022 05:24
TomShawn
TomShawn reviewed Mar 24, 2022
View reviewed changes
tikv-configuration-file.md Outdated

### `foreground-cpu-time` <span class="version-mark">从 v6.0 版本开始引入</span>

+ 限制 CPU 为处理 TiKV 前台读写请求所使用的 CPU 资源使用量，这是一个软限制。
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
+ 限制 CPU 为处理 TiKV 前台读写请求所使用的 CPU 资源使用量，这是一个软限制。
+ 限制处理 TiKV 前台读写请求所使用的 CPU 资源使用量，这是一个软限制。

TomShawn
TomShawn approved these changes Mar 24, 2022
View reviewed changes
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest LGTM

en-jin19
en-jin19 approved these changes Mar 24, 2022
View reviewed changes
Copy link
Contributor

@en-jin19 en-jin19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 24, 2022
@en-jin19
Copy link
Contributor

LGTM

Hi @tonyxuqqi, could you please approve this PR? thank you!

@tonyxuqqi tonyxuqqi self-assigned this Mar 24, 2022
@en-jin19
Copy link
Contributor

/remove-status LGT1
/status LGT2

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 25, 2022
@en-jin19
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 7309105

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 25, 2022
@ti-chi-bot ti-chi-bot merged commit e31a129 into pingcap:master Mar 25, 2022
@hunterlxt hunterlxt deleted the xt/quota-doc branch March 25, 2022 06:44
@en-jin19 en-jin19 mentioned this pull request Mar 28, 2022
Merged
15 tasks
@en-jin19 en-jin19 added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Mar 28, 2022
TomShawn
TomShawn reviewed Mar 29, 2022
View reviewed changes
tikv-configuration-file.md
> **警告：**
>
> - 前台限流是 TiDB 在 v6.0.0 中引入的实验特性，不建议在生产环境中使用。
> - 该功能仅适合在资源有限的环境中使用，以保证 TiKV 在该环境下可以长期稳定地运行。如果在资源丰富的机型环境中开启该功能，可能会导致读写请求量达到峰值时 TiKV 的性能下降的问题。
Copy link
Contributor

@TomShawn TomShawn Mar 29, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

感觉”长期“比较含糊。多长是”长期“呢？

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个时间点是：当后台的工作无法可持续的完成，不断累积更多待处理的任务以后，且后台累积任务而导致 write stall 等情况发生，从而使这个时间点以后的请求处理的时间无法和之前的处理时间相当

@en-jin19 en-jin19 changed the title tikv: add quota limiter doc in config TiKV: add quota limiter doc in config Apr 2, 2022
@en-jin19 en-jin19 mentioned this pull request Apr 2, 2022
Merged
15 tasks
@ti-chi-bot ti-chi-bot mentioned this pull request Apr 6, 2022
Merged
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomShawn TomShawn TomShawn approved these changes

@en-jin19 en-jin19 en-jin19 approved these changes

@tonyxuqqi tonyxuqqi tonyxuqqi approved these changes

Assignees

@tonyxuqqi tonyxuqqi

@hunterlxt hunterlxt

@en-jin19 en-jin19

Labels
area/engine Indicates that the Issue or PR belongs to the area of TP storage or Cloud storage. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. v6.0 This PR/issue applies to TiDB v6.0.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hunterlxt @ti-chi-bot @en-jin19 @tonyxuqqi @TomShawn