-
Notifications
You must be signed in to change notification settings - Fork 687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
data-type-string: Corrections (#11155) #11256
data-type-string: Corrections (#11155) #11256
Conversation
Co-authored-by: TomShawn <[email protected]>
Co-authored-by: TomShawn <[email protected]>
Co-authored-by: TomShawn <[email protected]>
Co-authored-by: TomShawn <[email protected]>
Co-authored-by: TomShawn <[email protected]>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 2846fb2
|
This is an automated cherry-pick of #11155
What is changed, added or deleted? (Required)
TEXT(M)
From the mysql docs on string data types:
So:
TEXT(60)
results inTINYTEXT
(60×4=240, which is less than 255)TEXT(70)
results inTEXT
(70×4=280, which is more than 255)TEXT(70) CHARACTER SET ASCII
results inTINYTEXT
(70×1=70, which is less than 255)This is to show that a
TEXT(0)
can actually hold a string of 9 characters (and 9 bytes).This error says this is the display width, but I don't think that's really true as that is only used for integer types.
Closes #4014
Which TiDB version(s) do your changes apply to? (Required)
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?