Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AUTO_INCREMENT: Capitalize sql keywords #4116

Merged
merged 3 commits into from
Nov 2, 2020
Merged

AUTO_INCREMENT: Capitalize sql keywords #4116

merged 3 commits into from
Nov 2, 2020

Conversation

spencerkee
Copy link
Contributor

why: issue: #699

What is changed, added or deleted? (Required)

Capitalize sql keywords

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Have version specific changes
  • Might cause conflicts

@ti-srebot ti-srebot added the first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. label Oct 30, 2020
@CLAassistant
Copy link

CLAassistant commented Oct 30, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@ghost
Copy link

ghost commented Oct 30, 2020

@spencerkee Thank you for your contribution! Can you please sign the CLA?

@ghost
Copy link

ghost commented Oct 30, 2020

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 30, 2020
@spencerkee
Copy link
Contributor Author

@nullnotnil Done, any chance you could add the hacktoberfest-accepted label to this pr if merging will take longer than the 31st?

@ghost ghost added the hacktoberfest-accepted This PR is accepted in Hacktoberfest. label Nov 1, 2020
TomShawn
TomShawn approved these changes Nov 2, 2020
View reviewed changes
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot removed the status/LGT1 Indicates that a PR has LGTM 1. label Nov 2, 2020
@ti-srebot ti-srebot added the status/LGT2 Indicates that a PR has LGTM 2. label Nov 2, 2020
@TomShawn TomShawn added needs-cherry-pick-4.0 size/small Changes of a small size. translation/doing This PR's assignee is translating this PR. labels Nov 2, 2020
@TomShawn TomShawn merged commit 5fa98d9 into pingcap:master Nov 2, 2020
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Nov 2, 2020
@spencerkee @ti-srebot
cherry pick pingcap#4116 to release-4.0
821fd71 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Nov 2, 2020
Merged
9 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #4119

TomShawn pushed a commit that referenced this pull request Nov 2, 2020
@ti-srebot @spencerkee
cherry pick #4116 to release-4.0 (#4119)
5bdbdb8 
Signed-off-by: ti-srebot <[email protected]>

Co-authored-by: spencerkee <[email protected]>
@Joyinqin
Copy link
Contributor

Joyinqin commented Nov 3, 2020

/label translation/done

@ti-srebot ti-srebot added the translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. label Nov 3, 2020
@Joyinqin
Copy link
Contributor

Joyinqin commented Nov 3, 2020

/unlabel translation/doing

@ti-srebot ti-srebot removed the translation/doing This PR's assignee is translating this PR. label Nov 3, 2020
@Joyinqin Joyinqin mentioned this pull request Nov 3, 2020
Merged
9 tasks
@ti-srebot ti-srebot mentioned this pull request Nov 3, 2020
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ti-srebot ti-srebot ti-srebot approved these changes

@TomShawn TomShawn TomShawn approved these changes

Assignees

@Joyinqin Joyinqin

Labels
first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. hacktoberfest-accepted This PR is accepted in Hacktoberfest. size/small Changes of a small size. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@spencerkee @CLAassistant @ti-srebot @Joyinqin @TomShawn