-
Notifications
You must be signed in to change notification settings - Fork 687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Capitalize sql keywords in several files #4117
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, just a minor comment. Thanks for picking this up!
@nullnotnil Changes addressed. Any chance you could add |
LGTM |
Certainly. I've added it, please let me know if you have any problems :-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: ti-srebot <[email protected]>
cherry pick to release-2.1 in PR #4120 |
Signed-off-by: ti-srebot <[email protected]>
cherry pick to release-3.0 in PR #4121 |
Signed-off-by: ti-srebot <[email protected]>
cherry pick to release-3.1 in PR #4122 |
Signed-off-by: ti-srebot <[email protected]>
cherry pick to release-4.0 in PR #4123 |
Signed-off-by: ti-srebot <[email protected]> Co-authored-by: spencerkee <[email protected]>
* cherry pick #4117 to release-3.1 Signed-off-by: ti-srebot <[email protected]> * resolve conflicts Co-authored-by: spencerkee <[email protected]> Co-authored-by: TomShawn <[email protected]>
* cherry pick #4117 to release-3.0 Signed-off-by: ti-srebot <[email protected]> * resolve conflicts Co-authored-by: spencerkee <[email protected]> Co-authored-by: TomShawn <[email protected]>
* cherry pick #4117 to release-2.1 Signed-off-by: ti-srebot <[email protected]> * resolve conflicts Co-authored-by: spencerkee <[email protected]> Co-authored-by: TomShawn <[email protected]>
why: issue: #699
What is changed, added or deleted? (Required)
Capitalize sql keywords in:
Which TiDB version(s) do your changes apply to? (Required)
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?