Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capitalize sql keywords in several files #4117

Merged
merged 7 commits into from
Nov 2, 2020

Conversation

spencerkee
Copy link
Contributor

@spencerkee spencerkee commented Oct 31, 2020

why: issue: #699

What is changed, added or deleted? (Required)

Capitalize sql keywords in:

auto-random.md
backup-and-restore-using-dumpling-lightning.md
backup-and-restore-using-mydumper-lightning.md
basic-sql-operations.md
blocklist-control-plan.md
character-set-and-collation.md

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Have version specific changes
  • Might cause conflicts

@ti-srebot ti-srebot added the first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. label Oct 31, 2020
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, just a minor comment. Thanks for picking this up!

blocklist-control-plan.md Outdated Show resolved Hide resolved
@spencerkee
Copy link
Contributor Author

Looking good, just a minor comment. Thanks for picking this up!

@nullnotnil Changes addressed. Any chance you could add hacktoberfest-accepted to this pr and my other?

@ghost ghost added the hacktoberfest-accepted This PR is accepted in Hacktoberfest. label Nov 1, 2020
@ghost
Copy link

ghost commented Nov 1, 2020

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 1, 2020
@ghost
Copy link

ghost commented Nov 1, 2020

@nullnotnil Changes addressed. Any chance you could add hacktoberfest-accepted to this pr and my other?

Certainly. I've added it, please let me know if you have any problems :-)

@TomShawn TomShawn added needs-cherry-pick-2.1 requires-version-specific-changes After cherry-picked, the cherry-picked PR requires further changes. labels Nov 2, 2020
@TomShawn TomShawn self-assigned this Nov 2, 2020
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot removed the status/LGT1 Indicates that a PR has LGTM 1. label Nov 2, 2020
@ti-srebot ti-srebot added the status/LGT2 Indicates that a PR has LGTM 2. label Nov 2, 2020
@TomShawn TomShawn added the size/small Changes of a small size. label Nov 2, 2020
@TomShawn TomShawn merged commit 8595ca5 into pingcap:master Nov 2, 2020
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Nov 2, 2020
@ti-srebot
Copy link
Contributor

cherry pick to release-2.1 in PR #4120

ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Nov 2, 2020
@ti-srebot
Copy link
Contributor

cherry pick to release-3.0 in PR #4121

ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Nov 2, 2020
@ti-srebot
Copy link
Contributor

cherry pick to release-3.1 in PR #4122

ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Nov 2, 2020
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #4123

TomShawn pushed a commit that referenced this pull request Nov 2, 2020
Signed-off-by: ti-srebot <[email protected]>

Co-authored-by: spencerkee <[email protected]>
TomShawn added a commit that referenced this pull request Nov 2, 2020
* cherry pick #4117 to release-3.1

Signed-off-by: ti-srebot <[email protected]>

* resolve conflicts

Co-authored-by: spencerkee <[email protected]>
Co-authored-by: TomShawn <[email protected]>
TomShawn added a commit that referenced this pull request Nov 2, 2020
* cherry pick #4117 to release-3.0

Signed-off-by: ti-srebot <[email protected]>

* resolve conflicts

Co-authored-by: spencerkee <[email protected]>
Co-authored-by: TomShawn <[email protected]>
TomShawn added a commit that referenced this pull request Nov 2, 2020
* cherry pick #4117 to release-2.1

Signed-off-by: ti-srebot <[email protected]>

* resolve conflicts

Co-authored-by: spencerkee <[email protected]>
Co-authored-by: TomShawn <[email protected]>
@TomShawn TomShawn added translation/doing This PR's assignee is translating this PR. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR's assignee is translating this PR. labels Nov 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. hacktoberfest-accepted This PR is accepted in Hacktoberfest. requires-version-specific-changes After cherry-picked, the cherry-picked PR requires further changes. size/small Changes of a small size. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants